[BUG] Failure to use docker_overrides for custom SELKIES_* envs

[MafiaInc]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

I'm trying to create my first selaskin apps repository and want to customize some settings as follows:

docker_overrides:
  environment:
    - "SELKIES_MANUAL_WIDTH=1920"
    - "SELKIES_MANUAL_HEIGHT=1080"
    - "MAX_RESOLUTION=1920x1080"
    - "RESTART_APP=true"
    - "SELKIES_ENCODER=x264enc-striped"
    - "SELKIES_USE_BROWSER_CURSORS=true"

I figured that this doesn't merge my custom variables with the new container, instead replacing the default environment variables which breaks the container.
Important variables like : SUBFOLDER, CUSTOM_USER, PASSWORD are wiped out.

Expected Behavior

I would like to be able to customize SELKIES_* defaults somehow when installing application from app store. Expected behavior shall be to merge the environments with the default environments this allow modifications, not replacing only.

Steps To Reproduce

1. Use the following in apps.yml to the application itself.

docker_overrides:
  environment:
    - "SELKIES_MANUAL_WIDTH=1920"
    - "SELKIES_MANUAL_HEIGHT=1080"
    - "MAX_RESOLUTION=1920x1080"
    - "RESTART_APP=true"
    - "SELKIES_ENCODER=x264enc-striped"
    - "SELKIES_USE_BROWSER_CURSORS=true"

2. Add the app store in the SealSkin control panel in the extension and install and run the app.
3. Confirm that the app will not start

Environment

- OS: Proxmox
- How docker service was installed: I use LXC in Proxmox to start sealskin sever in docker. I have Nvidia passthrough to the LXC container.

CPU architecture

x86-64

Docker creation

---
services:
  sealskin:
    image: lscr.io/linuxserver/sealskin:latest
    container_name: sealskin
    environment:
      - PUID=9090
      - PGID=9090
      - TZ=Europe/Sofia
      - HOST_URL=sealskin.example.net
    volumes:
      - /storage/sealskin/config:/config
      - /storage/sealskin/storage:/storage
      - /var/run/docker.sock:/var/run/docker.sock
    ports:
      - 8443:8443
      - 8000:8000
    restart: unless-stopped

Container logs

Not an issue in the sealskin container itself.

[github-actions]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[MafiaInc]

Found a temporary workaround which seems working:

    docker_overrides:
      entrypoint: ["/bin/bash", "-c", "export SELKIES_MANUAL_WIDTH=1920 SELKIES_MANUAL_HEIGHT=1080 SELKIES_IS_MANUAL_RESOLUTION_MODE=true MAX_RESOLUTION=1920x1080 SELKIES_ENCODER=x264enc-striped; exec /init"]

[thelamer]

All of those options are supposed to be on the user, the docker override section is specifically meant for vars we do not already cover with application templates.

This is a design decision, I do not have plans to include application template related variables in the apps repo. But if someone wanted to implement it properly and document it I have no problem with that.