Skip to content

fix: Set max-age for image files to 300 seconds#189

Closed
MattKobayashi wants to merge 1 commit intolinuxserver:masterfrom
MattKobayashi:no-cache-images
Closed

fix: Set max-age for image files to 300 seconds#189
MattKobayashi wants to merge 1 commit intolinuxserver:masterfrom
MattKobayashi:no-cache-images

Conversation

@MattKobayashi
Copy link
Copy Markdown
Contributor

@MattKobayashi MattKobayashi commented Mar 20, 2025

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Enable the mod_expires Apache module, and configure it to request that image files are expired from the browser cache after 5 minutes (max-age=300).

Benefits of this PR and context:

Currently, preview graphs are returned with max-age=14400 in the Cache-Control HTTP response header. This means that preview graphs persist in the browser cache, and a forced reload is the only way to refresh them. This PR enables the mod_expires Apache module and configures it to request that image files are expired from the browser cache after 5 minutes (max-age=300).

How Has This Been Tested?

Container builds and runs successfully. Images now have max-age=300 set in the Cache-Control HTTP response header, according to the browser developer console.

Source / References:

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-b8b8881c-dev-9bcdf686552cc49f999c7f255234cfe1641d904b-pr-189/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-b8b8881c-dev-9bcdf686552cc49f999c7f255234cfe1641d904b-pr-189/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-b8b8881c-dev-9bcdf686552cc49f999c7f255234cfe1641d904b-pr-189
arm64v8-2.8.2-r3-pkg-b8b8881c-dev-9bcdf686552cc49f999c7f255234cfe1641d904b-pr-189

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-b8b8881c-dev-21656cc84de83c64a7eadd1274301dccf54d6074-pr-189/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-b8b8881c-dev-21656cc84de83c64a7eadd1274301dccf54d6074-pr-189/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-b8b8881c-dev-21656cc84de83c64a7eadd1274301dccf54d6074-pr-189
arm64v8-2.8.2-r3-pkg-b8b8881c-dev-21656cc84de83c64a7eadd1274301dccf54d6074-pr-189

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5be6fcde-dev-ca3df8f2f2f6fe255aad4154ab23a40b70e480e9-pr-189/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5be6fcde-dev-ca3df8f2f2f6fe255aad4154ab23a40b70e480e9-pr-189/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-5be6fcde-dev-ca3df8f2f2f6fe255aad4154ab23a40b70e480e9-pr-189
arm64v8-2.8.2-r3-pkg-5be6fcde-dev-ca3df8f2f2f6fe255aad4154ab23a40b70e480e9-pr-189

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-ed6dce9e-dev-b1076c2bc32a6d4a7e7c61dd570887ea51c845be-pr-189/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-ed6dce9e-dev-b1076c2bc32a6d4a7e7c61dd570887ea51c845be-pr-189/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-ed6dce9e-dev-b1076c2bc32a6d4a7e7c61dd570887ea51c845be-pr-189
arm64v8-2.8.2-r3-pkg-ed6dce9e-dev-b1076c2bc32a6d4a7e7c61dd570887ea51c845be-pr-189

@MattKobayashi
Copy link
Copy Markdown
Contributor Author

Any chance of getting this merged? Happy to discuss any feedback or any changes that should be made as well.

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-8b437131-dev-a9e833fbd7eb42bf5f8b8dc528c52799b232c354-pr-189/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-8b437131-dev-a9e833fbd7eb42bf5f8b8dc528c52799b232c354-pr-189/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-8b437131-dev-a9e833fbd7eb42bf5f8b8dc528c52799b232c354-pr-189
arm64v8-2.8.2-r3-pkg-8b437131-dev-a9e833fbd7eb42bf5f8b8dc528c52799b232c354-pr-189

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-53d767fd-dev-13c1eaaa59027ec9c1cf916188aa2aaca1e15a41-pr-189/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-53d767fd-dev-13c1eaaa59027ec9c1cf916188aa2aaca1e15a41-pr-189/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-53d767fd-dev-13c1eaaa59027ec9c1cf916188aa2aaca1e15a41-pr-189
arm64v8-2.8.2-r3-pkg-53d767fd-dev-13c1eaaa59027ec9c1cf916188aa2aaca1e15a41-pr-189

@thespad thespad mentioned this pull request Jun 3, 2025
1 task
@thespad
Copy link
Copy Markdown
Member

thespad commented Jun 3, 2025

Superseded by #196

@thespad thespad closed this Jun 3, 2025
@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants