Skip to content

Conversation

@RobinDadswell
Copy link
Contributor

@RobinDadswell RobinDadswell commented Feb 25, 2022

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds support for Azure DNS as a DNS plugin

Benefits of this PR and context:

Anyone that uses Azure DNS as their DNS provider will be able to utilise DNS-01 challenges

How Has This Been Tested?

Tested container built by Jenkins (lspipepr/swag:1.23.0-PR-217) - gets certificate as expected using Azure DNS for wildcard certificate, proxy services work with this.

Source / References:

Rox pointed me in the right places on Discord in messages starting here https://discord.com/channels/354974912613449730/805754854982025246/946532138088542208

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

1 similar comment
@LinuxServer-CI
Copy link
Contributor

Comment on lines +1 to +26
# Instructions: https://certbot-dns-azure.readthedocs.io/en/latest/
# Replace with your values
# dns_azure_environment can be one of the following: AzurePublicCloud, AzureUSGovernmentCloud, AzureChinaCloud, AzureGermanCloud
# Service Principal with Client Secret
dns_azure_sp_client_id = 912ce44a-0156-4669-ae22-c16a17d34ca5
dns_azure_sp_client_secret = E-xqXU83Y-jzTI6xe9fs2YC~mck3ZzUih9
dns_azure_tenant_id = ed1090f3-ab18-4b12-816c-599af8a88cf7
dns_azure_environment = "AzurePublicCloud"
dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1


# Service Prinicipal with Certificate
#dns_azure_sp_client_id = 912ce44a-0156-4669-ae22-c16a17d34ca5
#dns_azure_sp_certificate_path = /path/to/certificate.pem
#dns_azure_tenant_id = ed1090f3-ab18-4b12-816c-599af8a88cf7
#dns_azure_environment = "AzurePublicCloud"
#dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1

# Azure Managed Identity
#dns_azure_msi_client_id = 912ce44a-0156-4669-ae22-c16a17d34ca5
#dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1

# System Assigned Azure Managed Identity
#dns_azure_msi_system_assigned = true
#dns_azure_environment = "AzurePublicCloud"
#dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all example config has come from the docs site for certbot-dns-azure

@LinuxServer-CI
Copy link
Contributor

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@RobinDadswell
Copy link
Contributor Author

This is waiting for feedback/merge and isn't with me so shoild be excluded from the Bot

@LinuxServer-CI
Copy link
Contributor

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@RobinDadswell
Copy link
Contributor Author

@Roxedus can you get this excluded from stale bot? It's on someone at LSIO to look at and provide feedback :)

@Roxedus Roxedus merged commit ef95db3 into linuxserver:master May 18, 2022
@aptalca
Copy link
Member

aptalca commented May 18, 2022

missing other dockerfiles and incorrectly inserted into init file and changelog entry

@aptalca aptalca mentioned this pull request May 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants