-
-
Notifications
You must be signed in to change notification settings - Fork 277
New: Azure DNS support #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR: |
1 similar comment
|
I am a bot, here are the test results for this PR: |
35a0b41 to
82cb0ad
Compare
| # Instructions: https://certbot-dns-azure.readthedocs.io/en/latest/ | ||
| # Replace with your values | ||
| # dns_azure_environment can be one of the following: AzurePublicCloud, AzureUSGovernmentCloud, AzureChinaCloud, AzureGermanCloud | ||
| # Service Principal with Client Secret | ||
| dns_azure_sp_client_id = 912ce44a-0156-4669-ae22-c16a17d34ca5 | ||
| dns_azure_sp_client_secret = E-xqXU83Y-jzTI6xe9fs2YC~mck3ZzUih9 | ||
| dns_azure_tenant_id = ed1090f3-ab18-4b12-816c-599af8a88cf7 | ||
| dns_azure_environment = "AzurePublicCloud" | ||
| dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1 | ||
|
|
||
|
|
||
| # Service Prinicipal with Certificate | ||
| #dns_azure_sp_client_id = 912ce44a-0156-4669-ae22-c16a17d34ca5 | ||
| #dns_azure_sp_certificate_path = /path/to/certificate.pem | ||
| #dns_azure_tenant_id = ed1090f3-ab18-4b12-816c-599af8a88cf7 | ||
| #dns_azure_environment = "AzurePublicCloud" | ||
| #dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1 | ||
|
|
||
| # Azure Managed Identity | ||
| #dns_azure_msi_client_id = 912ce44a-0156-4669-ae22-c16a17d34ca5 | ||
| #dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1 | ||
|
|
||
| # System Assigned Azure Managed Identity | ||
| #dns_azure_msi_system_assigned = true | ||
| #dns_azure_environment = "AzurePublicCloud" | ||
| #dns_azure_zone1 = example.com:/subscriptions/c135abce-d87d-48df-936c-15596c6968a5/resourceGroups/dns1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all example config has come from the docs site for certbot-dns-azure
|
I am a bot, here are the test results for this PR: |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This is waiting for feedback/merge and isn't with me so shoild be excluded from the Bot |
82cb0ad to
3893db4
Compare
|
I am a bot, here are the test results for this PR: |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@Roxedus can you get this excluded from stale bot? It's on someone at LSIO to look at and provide feedback :) |
|
missing other dockerfiles |
Description:
Adds support for Azure DNS as a DNS plugin
Benefits of this PR and context:
Anyone that uses Azure DNS as their DNS provider will be able to utilise DNS-01 challenges
How Has This Been Tested?
Tested container built by Jenkins (lspipepr/swag:1.23.0-PR-217) - gets certificate as expected using Azure DNS for wildcard certificate, proxy services work with this.
Source / References:
Rox pointed me in the right places on Discord in messages starting here https://discord.com/channels/354974912613449730/805754854982025246/946532138088542208