Skip to content

Conversation

@nemchik
Copy link
Member

@nemchik nemchik commented Dec 8, 2022

  • Resolves incorrect handling of cpanel dns plugin introduced in Dns updates #277 by using correct new syntax and CLI arguments. Fixes cpanel plugun not working after rollback to 1.32.0 #303
  • Resolves newly required CLI arguments for directadmin plugin version 1.0.3 (and newer). Fixes [BUG] Directadmin DNS doesn't seem to work #307
  • Apply string replacements for dns plugin confs to renewal file /config/etc/letsencrypt/renewal/${ORIGDOMAIN}.conf, also rearrange script to keep existing string replacements for user config next to string replacements for renewal file. Fixes Cert renewal via Gandi DNS plugin fails #296
  • Move revocation logic up, mostly to keep cert issuing logic and preceding variable assignment closer together.
  • Rewrite PREFCHAL section
    • Almost all dns plugins use the same syntax for CLI arguments, so standardize the expected arguments and handle exceptions more specifically
    • route53 and standalone do not support setting a credential file via CLI argument (route53 credential file is defined using AWS_CONFIG_FILE in the Dockerfile)
    • azure, gandi and standalone do not support setting a propagation time via CLI argument
    • cpanel uses non-standard parameter naming conventions that will very likely be deprecated and fully removed in a future release of certbot (maybe already done in 2.0) but for now it can be used if handled specifically
    • duckdns works like most other standard plugins, but we add an extra CLI parameter (no-txt-restore) to prevent issues when using local DNS records (see Use --dns-duckdns-no-txt-restore flag #293)

@nemchik nemchik requested a review from a team December 8, 2022 15:48
@LinuxServer-CI
Copy link
Contributor

@LinuxServer-CI
Copy link
Contributor

@LinuxServer-CI
Copy link
Contributor

@LinuxServer-CI
Copy link
Contributor

Copy link
Member

@drizuid drizuid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm without testing
testing cpanel was completed by monologu
directadmin tested by the dev of directadmin

@drizuid drizuid merged commit 672c523 into master Jan 8, 2023
@drizuid drizuid deleted the certbot-revamp branch January 8, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Directadmin DNS doesn't seem to work cpanel plugun not working after rollback to 1.32.0 Cert renewal via Gandi DNS plugin fails

4 participants