-
-
Notifications
You must be signed in to change notification settings - Fork 277
Revamp certbot init #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp certbot init #306
Conversation
|
I am a bot, here are the test results for this PR: |
|
I am a bot, here are the test results for this PR: |
|
I am a bot, here are the test results for this PR: |
|
I am a bot, here are the test results for this PR: |
drizuid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm without testing
testing cpanel was completed by monologu
directadmin tested by the dev of directadmin
/config/etc/letsencrypt/renewal/${ORIGDOMAIN}.conf, also rearrange script to keep existing string replacements for user config next to string replacements for renewal file. Fixes Cert renewal via Gandi DNS plugin fails #296PREFCHALsectionroute53andstandalonedo not support setting a credential file via CLI argument (route53credential file is defined usingAWS_CONFIG_FILEin the Dockerfile)azure,gandiandstandalonedo not support setting a propagation time via CLI argumentcpaneluses non-standard parameter naming conventions that will very likely be deprecated and fully removed in a future release of certbot (maybe already done in 2.0) but for now it can be used if handled specificallyduckdnsworks like most other standard plugins, but we add an extra CLI parameter (no-txt-restore) to prevent issues when using local DNS records (see Use --dns-duckdns-no-txt-restore flag #293)