Skip to content

Unpin certbot version #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 22, 2023
Merged

Unpin certbot version #308

merged 5 commits into from
Jan 22, 2023

Conversation

@nemchik
Copy link
Member

@nemchik nemchik commented Dec 9, 2022 •
edited
Loading

@LinuxServer-CI
Copy link
Contributor

LinuxServer-CI commented Dec 9, 2022

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-bdbf434a-pr-308/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-bdbf434a-pr-308/shellcheck-result.xml

@nemchik nemchik requested a review from a team December 9, 2022 23:44
@LinuxServer-CI
Copy link
Contributor

LinuxServer-CI commented Dec 10, 2022

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-bdbf434a-pr-308/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-bdbf434a-pr-308/shellcheck-result.xml

@nemchik nemchik marked this pull request as draft December 10, 2022 01:13
@nemchik
Copy link
Member Author

nemchik commented Dec 10, 2022

Converted to draft until the porkbun plugin releases a new version. Currently version 0.6 includes a specific requirement for certbot to be less than version 2.0
https://github.com/infinityofspace/certbot_dns_porkbun/blob/v0.6/requirements.txt#L2
This causes certbot commands to fail, even if the porkbun plugin is not being used.
Their master branch already has this updated, but as of writing, no release has been made.

Aside from that, I tested with duckdns and had no other issues.

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@nemchik nemchik added awaiting-approval Stale exempt and removed no-pr-activity labels Jan 9, 2023
@nemchik nemchik mentioned this pull request Jan 21, 2023
Closed
@nemchik
Merge remote-tracking branch 'origin/master' into 2.1.0
f6529ad
@nemchik
Temporarily remove certbot-dns-porkbun
db1f5f8 
This commit can be reverted when certbot-dns-porkbun releases a version with certbot 2.x support
@nemchik
Unpin certbot version (allow certbot 2.x).
ba54174 
!!BREAKING CHANGE!! We are temporarily removing the certbot porkbun plugin until a new version is released that is compatible with certbot 2.x.
@LinuxServer-CI
Copy link
Contributor

LinuxServer-CI commented Jan 21, 2023

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-c4933c74-pr-308/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-c4933c74-pr-308/shellcheck-result.xml

@nemchik nemchik marked this pull request as ready for review January 22, 2023 00:14
@nemchik
Copy link
Member Author

nemchik commented Jan 22, 2023

Discord user confirmed this also resolves the issue with py cryptography in 1.32.0-ls173 not being compatible with certbot 1.x on armv7.
https://discord.com/channels/354974912613449730/1066480560542863442/1066519680514269244

@nemchik nemchik merged commit 494d0a1 into master Jan 22, 2023
@nemchik nemchik deleted the 2.1.0 branch January 22, 2023 00:54
@nemchik nemchik mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drizuid drizuid drizuid approved these changes

Assignees

No one assigned

Labels

awaiting-approval Stale exempt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nemchik @LinuxServer-CI @drizuid