Skip to content

Rebase to alpine 3.17 with php8.1 #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 21, 2023
Merged

Rebase to alpine 3.17 with php8.1 #315

merged 5 commits into from
Jan 21, 2023

Conversation

@nemchik
Copy link
Member

@nemchik nemchik commented Jan 21, 2023 •
edited
Loading

Other notable changes:

  • Actually get and use the pip package version when installing in the dockerfile
  • Remove base packages
  • Don't install apk packages for py3 cryptography/future (install with pip)
  • Remove pyc/pyo cleanup (size difference is not significant)
  • Replace cron init logic with docker-mod cron init logic
  • Replace nginx service location in renewal hooks

@LinuxServer-CI
Copy link
Contributor

LinuxServer-CI commented Jan 21, 2023

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-ea0c357e-pr-315/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-ea0c357e-pr-315/shellcheck-result.xml

@nemchik nemchik requested a review from a team January 21, 2023 05:15
@LinuxServer-CI
Copy link
Contributor

LinuxServer-CI commented Jan 21, 2023

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-ea0c357e-pr-315/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-ea0c357e-pr-315/shellcheck-result.xml

thespad
thespad reviewed Jan 21, 2023
View reviewed changes
@thespad
Copy link
Member

thespad commented Jan 21, 2023

Got this on startup of an existing container:

swag  | 2023-01-21 10:26:34,008 fail2ban.configreader   [380]: WARNING 'allowipv6' not defined in 'Definition'. Using default one: 'auto'

thespad
thespad reviewed Jan 21, 2023
View reviewed changes
@LinuxServer-CI
Copy link
Contributor

LinuxServer-CI commented Jan 21, 2023

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-ea0c357e-pr-315/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-ea0c357e-pr-315/shellcheck-result.xml

@nemchik nemchik requested a review from a team January 21, 2023 14:59
@nemchik nemchik merged commit 46e5156 into master Jan 21, 2023
@nemchik nemchik deleted the 3.17 branch January 21, 2023 19:24
@nemchik nemchik mentioned this pull request Jan 26, 2023
Merged
@NBPub NBPub mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thespad thespad thespad approved these changes

+1 more reviewer

@davidnewhall davidnewhall davidnewhall left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nemchik @LinuxServer-CI @thespad @davidnewhall