Comment Default Configs #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Contributor
|
I am a bot, here are the test results for this PR: |
nemchik
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments out credentials for AWS Route53
Description:
Reason for change - Explicitly providing incorrect credentials to the aws libraries will always result in an unauthorized request. When running on aws, providing no credentials allows the libraries to obtain temporary credentials from aws IMDS when an ec2 instance has assumed a role.
Commenting these lines out allows the libraries (boto3 in the case of certbot) to function as intended, while still indicating the format of these variables to any reader of this file.
Benefits of this PR and context:
Benefits users running swag on aws services who want to use dns verification with route53. It negatively impacts 0 users.
How Has This Been Tested?
Tested on an ec2 instance. Did not need to provide aws credentials after this was commenting out, due to instance having assumed role.