[BUG] "peer-socket-tos": defaults to "le"

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Every time you start the container, the "peer-socket-tos": value in the settings.json file gets replaced by "le", even if you change it with the container stopped.

Expected Behavior

It should honor the settings.json value or have a way to pass the env variable.

Steps To Reproduce

• Shutdown container.
• Edit settings.json, replace "peer-socket-tos": "le" to "peer-socket-tos": "default" or other possible value
• Start container
• Check value in settings.json with container open

Environment

- OS: Raspberry Pi OS Bullseye (Stable)
- How docker service was installed: Official repo

CPU architecture

arm64

Docker creation

version: "3"
services:
  transmission:
    image: lscr.io/linuxserver/transmission:latest
    container_name: transmission
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/London
      - USER=*******
      - PASS= *******
      - WHITELIST=
      - PEERPORT=*****
      - HOST_WHITELIST= 
    volumes:
      - /home/path/transmission:/config
      - /home/path:/downloads
      - /home/path/Watch:/watch
    ports:
      - 9091:9091
      - *****:*****
    restart: unless-stopped

Container logs

[migrations] started
[migrations] no migrations found

-------------------------------------
          _         ()
         | |  ___   _    __
         | | / __| | |  /  \
         | | \__ \ | | | () |
         |_| |___/ |_|  \__/


Brought to you by linuxserver.io
-------------------------------------

To support LSIO projects visit:
https://www.linuxserver.io/donate/
-------------------------------------
GID/UID
-------------------------------------

User uid:    1000
User gid:    1000
-------------------------------------

[custom-init] No custom files found, skipping...
[ls.io-init] done.

[github-actions]

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

[thespad]

As far as I can tell it only resets it to le if you provide an invalid value.

lowcost, throughput, lowdelay, all work fine and persist. Setting default or foo result in it being reset back to le on startup.

Looks like any DSCP value is valid too.

In my case, it's been working as "default" since forever, and according to Transmission Docs values haven't changed.

Possible values are "default", "lowcost", "throughput", "lowdelay" and "reliability".

Could it be an undocumented change in Transmission release? Or is that value check performed by the container?

[thespad]

We're not changing anything in the config other than if you set the specific envs in the readme (user, pass, peerport, etc.), I suspect it's an undocumented change in v4.

Apparently yes, it's an undocumented change.

DSCP support was added initially in this commit and the latest change related to it listing the supported values for "peer-socket-tos" (DSCP and deprecated) can be found here, lines 351 to 390.

I guess you can close the issue, as is not container related. Thanks for the help.