Skip to content

[FEAT] Update Docker Compose Example #372

@somewatson

Description

@somewatson

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Add the websocket port to exposed ports for the docker compose example in the documentation

Right now the current default port is 8082.

Reason for change

The docker compose example has the following configuration for ports:

    ports:
      - 3000:3000
      - 3001:3001

However, since Webtop switched from Kasm to Selkies as the underlying base image, we also need to expose the websocket port. If you do not expose the websocket port, the container will only work initially. However, over time the performance will degrade and then the container will become unusable.

Proposed code change

The docker compose example ports section should be updated to:

    ports:
      - 3000:3000
      - 3001:3001
      - 8082:8082 # expose the websocket port, make sure this matches `SELKIES_PORT` (or `CUSTOM_WS_PORT`)

Happy to open up a PR and make the change to documentation myself. Not sure what the contribution policy is, I believe that some orgs require that PRs should be more than updates to documentation. Please let me know what the preference or policy is here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions