Skip to content

Create gaps.subdomain.conf.sample#394

Merged
drizuid merged 1 commit intolinuxserver:masterfrom
mtrolley:topic/gaps-subdomain
Nov 4, 2021
Merged

Create gaps.subdomain.conf.sample#394
drizuid merged 1 commit intolinuxserver:masterfrom
mtrolley:topic/gaps-subdomain

Conversation

@mtrolley
Copy link
Copy Markdown
Contributor

@mtrolley mtrolley commented Oct 20, 2021 •
edited
Loading

For container: https://hub.docker.com/r/housewrecker/gaps

Also fix small typo in portainer.subdirectory.conf.sample.

linuxserver.io

Thanks, team linuxserver.io

@mtrolley
Create gaps.subdomain.conf.sample
f771edb 
For container: https://hub.docker.com/r/housewrecker/gaps

Also fix small typo in portainer.subdirectory.conf.sample.
@mtrolley
Copy link
Copy Markdown
Contributor Author

mtrolley commented Oct 20, 2021

Subfolder sample was added in PR #325.

drizuid
drizuid reviewed Nov 4, 2021
View reviewed changes
Comment thread portainer.subfolder.conf.sample

rewrite /portainer(.*) $1 break;
proxy_hide_header X-Frame-Options; # Possibly nott needed after Portainer 1.20.0
proxy_hide_header X-Frame-Options; # Possibly not needed after Portainer 1.20.0
Copy link
Copy Markdown
Member

@drizuid drizuid Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this correction was made sep1, 2020

Copy link
Copy Markdown
Contributor Author

@mtrolley mtrolley Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're referring to. This file in the master branch currently has nott misspelled: https://github.com/linuxserver/reverse-proxy-confs/blob/master/portainer.subfolder.conf.sample

Copy link
Copy Markdown
Member

@drizuid drizuid Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i stand corrected, i missed that one

drizuid
drizuid previously requested changes Nov 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@drizuid drizuid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard, another typo was missed

@drizuid drizuid dismissed their stale review November 4, 2021 14:55

mistake

@mtrolley
Copy link
Copy Markdown
Contributor Author

mtrolley commented Nov 4, 2021

please remove the portainer config as it's superfluous per 54ede40#diff-b0f0b1ac69c24158e8d491aa7f372ec5fbdf57ad0a9423e94c334dc44b27bf66

That's a different line. In master the same comment appears on lines 28 and 40, and I'm just correcting the typo on line 28.

If you'd prefer a separate PR for that change I'm good to do that though.

@drizuid drizuid merged commit 0b4c128 into linuxserver:master Nov 4, 2021
@mtrolley
Copy link
Copy Markdown
Contributor Author

mtrolley commented Nov 4, 2021

Thanks @drizuid.

@mtrolley mtrolley deleted the topic/gaps-subdomain branch November 4, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drizuid drizuid drizuid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtrolley @drizuid