Update the server_name for uptime-kuma subdomain from uptime.* to uptime-kuma.*#415
Merged
nemchik merged 1 commit intolinuxserver:masterfrom Jan 5, 2022
Merged
Conversation
Contributor
Author
|
@Starker3 FYI |
nemchik
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to keep the consistency. I spent some time before realizing that
uptime-kumaneeds a subdomain as onlyuptimethis is a bit misleading and effectively prevents someone from using another container in the same network called justuptimewhich nothing to do withuptime-kuma.Not sure how this would affect the backward compatibility, just thought of updating it in case this was a mistake. plus the original file added very recently making the impact lower.
Thanks
Thanks, team linuxserver.io