Skip to content

Proxy conf for Leantime#467

Merged
nemchik merged 6 commits intolinuxserver:masterfrom
mentallyinspired:patch-1
Feb 19, 2023
Merged

Proxy conf for Leantime#467
nemchik merged 6 commits intolinuxserver:masterfrom
mentallyinspired:patch-1

Conversation

@mentallyinspired
Copy link
Copy Markdown
Contributor

Proxy configuration for the project management tool Leantime.
https://leantime.io

linuxserver.io

Thanks, team linuxserver.io

Comment thread leantime.subdomain.conf.sample Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 3, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Copy Markdown
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proxy templates have been updated with new descriptive comments and auth lines. Please update your PR accordingly.

Ref:
https://github.com/linuxserver/reverse-proxy-confs/blob/master/_template.subdomain.conf.sample
https://github.com/linuxserver/reverse-proxy-confs/blob/master/_template.subfolder.conf.sample

Added required info about container name and dns cname
Copy link
Copy Markdown
Contributor Author

@mentallyinspired mentallyinspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNS cname info and container name info text

@mentallyinspired mentallyinspired requested review from nemchik and removed request for Roxedus February 19, 2023 08:51
Copy link
Copy Markdown
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might seem real picky, but having all the comments consistent makes it easier for end users to use and easier for us to maintain (especially when we have to do mass find/replace).

Comment thread leantime.subdomain.conf.sample Outdated
Comment thread leantime.subdomain.conf.sample Outdated
Update of consistency for comments

Co-authored-by: Eric Nemchik <eric@nemchik.com>
done

Co-authored-by: Eric Nemchik <eric@nemchik.com>
Copy link
Copy Markdown
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@nemchik nemchik dismissed Roxedus’s stale review February 19, 2023 20:19

Resolved in new commits

@nemchik nemchik merged commit dc840ba into linuxserver:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants