Skip to content

Create wrapperr.subdomain.conf.sample#510

Merged
nemchik merged 3 commits intolinuxserver:masterfrom
MountainGod2:develop
Feb 17, 2023
Merged

Create wrapperr.subdomain.conf.sample#510
nemchik merged 3 commits intolinuxserver:masterfrom
MountainGod2:develop

Conversation

@MountainGod2
Copy link
Copy Markdown
Contributor

linuxserver.io

Thanks, team linuxserver.io

@MountainGod2
Copy link
Copy Markdown
Contributor Author

Docker hub page to verify ports and name are correct:
https://hub.docker.com/r/aunefyren/wrapperr

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Copy Markdown
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proxy templates have been updated with new descriptive comments and auth lines. Please update your PR accordingly.

Ref:
https://github.com/linuxserver/reverse-proxy-confs/blob/master/_template.subdomain.conf.sample
https://github.com/linuxserver/reverse-proxy-confs/blob/master/_template.subfolder.conf.sample

@MountainGod2
Copy link
Copy Markdown
Contributor Author

Just curious, regarding the version date at the top of the file, is that the template date, or the date the config was created? I updated to today's date, so if that needs to be adjusted, no problem.

@MountainGod2 MountainGod2 requested a review from nemchik February 17, 2023 14:47
@thespad
Copy link
Copy Markdown
Member

thespad commented Feb 17, 2023

Just curious, regarding the version date at the top of the file, is that the template date, or the date the config was created? I updated to today's date, so if that needs to be adjusted, no problem.

It's the date the conf was created or last significantly modified, it's used to notify users when something important has changed and they may need to update their version of the file.

Copy link
Copy Markdown
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@nemchik nemchik merged commit 41f69e5 into linuxserver:master Feb 17, 2023
@MountainGod2 MountainGod2 deleted the develop branch February 17, 2023 16:39
@github-actions
Copy link
Copy Markdown

This pull request is locked due to inactivity

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants