Add dsmrreader.subdomain.conf.sample#535
Add dsmrreader.subdomain.conf.sample#535golles wants to merge 2 commits intolinuxserver:masterfrom golles:patch-2
dsmrreader.subdomain.conf.sample#535Conversation
dsmrreader.subdomain.confdsmrreader.subdomain.conf.sample
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Feel free to decline this PR if you think it has no added value. |
nemchik
left a comment
There was a problem hiding this comment.
Auth lines need to be commented by default. Otherwise it looks good to me.
| #include /config/nginx/ldap-server.conf; | ||
|
|
||
| # enable for Authelia (requires authelia-location.conf in the location block) | ||
| include /config/nginx/authelia-server.conf; |
There was a problem hiding this comment.
| include /config/nginx/authelia-server.conf; | |
| #include /config/nginx/authelia-server.conf; |
| #include /config/nginx/ldap-location.conf; | ||
|
|
||
| # enable for Authelia (requires authelia-server.conf in the server block) | ||
| include /config/nginx/authelia-location.conf; |
There was a problem hiding this comment.
| include /config/nginx/authelia-location.conf; | |
| #include /config/nginx/authelia-location.conf; |
|
@nemchik Thank you for the feedback, I missed restoring these lines from how I use them. I think I have to recreate new PR's for this, I will do this soon |
That sounds about right. I normally would have just edited the files myself for such a small change and accepted the PRs. On these two PRs I was not able to edit (because the repo/branch had been removed). You might be able to make new branches in your repo and then visit https://github.com/linuxserver/reverse-proxy-confs/pull/535/commits and copy the commit sha for both and cherry pick the commits. Otherwise just copy the contents of https://github.com/linuxserver/reverse-proxy-confs/blob/9bfd56ef05742f5795b8b1f5fd701e9a7413c7a3/dsmrreader.subdomain.conf.sample into a new branch (and comment the auth lines) and make a new PR and close these. |
|
That was a nice idea, but that didn't work, as there is no place where I can cherry-pick that commit from. I've created #553 te replace this PR, sorry for the trouble |
Description
Subdomain configuration for DSMR-reader
Benefits of this PR and context
This is an addition to your amazing collection of configurations. I wanted to share this one
How Has This Been Tested?
I've been using this config since Dec 12, 2020.
Source / References
https://github.com/dsmrreader/dsmr-reader