Skip to content

Add dsmrreader.subdomain.conf.sample#535

Closed
golles wants to merge 2 commits intolinuxserver:masterfrom
golles:patch-2
Closed

Add dsmrreader.subdomain.conf.sample#535
golles wants to merge 2 commits intolinuxserver:masterfrom
golles:patch-2

Conversation

@golles
Copy link
Copy Markdown
Contributor

@golles golles commented Feb 23, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description

Subdomain configuration for DSMR-reader

Benefits of this PR and context

This is an addition to your amazing collection of configurations. I wanted to share this one

How Has This Been Tested?

I've been using this config since Dec 12, 2020.

Source / References

https://github.com/dsmrreader/dsmr-reader

@golles golles changed the title Add dsmrreader.subdomain.conf Add dsmrreader.subdomain.conf.sample Feb 23, 2023
@golles golles closed this by deleting the head repository Feb 23, 2023
@golles golles reopened this Feb 24, 2023
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@golles
Copy link
Copy Markdown
Contributor Author

golles commented Mar 29, 2023

Feel free to decline this PR if you think it has no added value.

Copy link
Copy Markdown
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth lines need to be commented by default. Otherwise it looks good to me.

#include /config/nginx/ldap-server.conf;

# enable for Authelia (requires authelia-location.conf in the location block)
include /config/nginx/authelia-server.conf;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include /config/nginx/authelia-server.conf;
#include /config/nginx/authelia-server.conf;

#include /config/nginx/ldap-location.conf;

# enable for Authelia (requires authelia-server.conf in the server block)
include /config/nginx/authelia-location.conf;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include /config/nginx/authelia-location.conf;
#include /config/nginx/authelia-location.conf;

@golles
Copy link
Copy Markdown
Contributor Author

golles commented Apr 13, 2023

@nemchik Thank you for the feedback, I missed restoring these lines from how I use them.
I think I screwed up both PR's. I deleted the fork of this repo (golles closed this by deleting the head repository on Feb 23), I was able to reopen the PR's by forking it again, however, I don't have the tracking branches any longer.
Usually, there is a commit suggestion next to a code suggestion comment.

I think I have to recreate new PR's for this, I will do this soon

@nemchik
Copy link
Copy Markdown
Member

nemchik commented Apr 13, 2023

@nemchik Thank you for the feedback, I missed restoring these lines from how I use them. I think I screwed up both PR's. I deleted the fork of this repo (golles closed this by deleting the head repository on Feb 23), I was able to reopen the PR's by forking it again, however, I don't have the tracking branches any longer. Usually, there is a commit suggestion next to a code suggestion comment.

I think I have to recreate new PR's for this, I will do this soon

That sounds about right. I normally would have just edited the files myself for such a small change and accepted the PRs. On these two PRs I was not able to edit (because the repo/branch had been removed). You might be able to make new branches in your repo and then visit https://github.com/linuxserver/reverse-proxy-confs/pull/535/commits and copy the commit sha for both and cherry pick the commits. Otherwise just copy the contents of https://github.com/linuxserver/reverse-proxy-confs/blob/9bfd56ef05742f5795b8b1f5fd701e9a7413c7a3/dsmrreader.subdomain.conf.sample into a new branch (and comment the auth lines) and make a new PR and close these.

@golles golles mentioned this pull request Apr 15, 2023
1 task
@golles
Copy link
Copy Markdown
Contributor Author

golles commented Apr 15, 2023

That was a nice idea, but that didn't work, as there is no place where I can cherry-pick that commit from. I've created #553 te replace this PR, sorry for the trouble

@golles golles closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants