added fenrus and wordpress.subdomain.conf.sample#539
Merged
nemchik merged 8 commits intolinuxserver:masterfrom Mar 18, 2023
ZlabiDev:master
Merged
added fenrus and wordpress.subdomain.conf.sample#539nemchik merged 8 commits intolinuxserver:masterfrom ZlabiDev:master
nemchik merged 8 commits intolinuxserver:masterfrom
ZlabiDev:master
Conversation
drizuid
approved these changes
Mar 11, 2023
Member
drizuid
left a comment
drizuid
left a comment
There was a problem hiding this comment.
Visual inspection from mobile, lgtm
drizuid
changed the title
nemchik
requested changes
Mar 11, 2023
Co-authored-by: Eric Nemchik <eric@nemchik.com>
Co-authored-by: Eric Nemchik <eric@nemchik.com>
Co-authored-by: Eric Nemchik <eric@nemchik.com>
ZlabiDev
changed the title
nemchik
reviewed
Mar 12, 2023
Member
nemchik
left a comment
nemchik
left a comment
There was a problem hiding this comment.
I noticed one last thing. Everything else looks good.
As a side note, in the future it would be preferred to add config samples for each app separately. If you are doing a subdomain and subfolder config for a single app in a single PR that's fine, but two entirely separate apps would be better as two separate PRs. The main benefit is one could merge without waiting for the other if only one needs adjustments.
nemchik
approved these changes
Mar 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds
fenrus.subdomain.conf.samplebased on the template_template.subdomain.conf.sample.This adds
wordpress.subdomain.conf.samplebased on the template_template.subdomain.conf.sample.Benefits of this PR and context
I've setup Fenrus Dashboard on my unraid server and run it behind the swag reverse-proxy and now i would like to share the config for other people.
How Has This Been Tested?
I've been using this SWAG subdomain configuration for a while now. SWAG runs on my unraid server and is used to work as reverse-proxy and to optain SSL CERTs. It worked great.
Source / References
fenrus on DockerHub
fenrus on Github
Wordpress