Skip to content

added pterodactyl config#571

Merged
nemchik merged 8 commits intolinuxserver:masterfrom
GetLifty:master
May 20, 2023
Merged

added pterodactyl config#571
nemchik merged 8 commits intolinuxserver:masterfrom
GetLifty:master

Conversation

@GetLifty
Copy link
Copy Markdown
Contributor

@GetLifty GetLifty commented May 8, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description

Adds two new subdomain config files! One is for the pterodactyl game server panel, and the other is for pterodactyl nodes.

Benefits of this PR and context

Pterodactyl panel reverse proxy is not very well documented outside of their own implementation. When trying to set it up myself I found only one guide designed for nginx proxy manager and had to adapt from that.

How Has This Been Tested?

Tested on my personal setup. Works perfectly including API access, SFTP and other included features. Have also tested on a friends server to similar success.

Source / References

N/A

Comment thread pterodactylnode.subdomain.conf.sample Outdated
Comment thread pterodactylnode.subdomain.conf.sample
Comment thread pterodactylpanel.subdomain.conf.sample
Comment thread pterodactylnode.subdomain.conf.sample
@nemchik
Copy link
Copy Markdown
Member

nemchik commented May 20, 2023

8355cdc this isn't what I meant about whitespace. Please keep 4 space indentation (not tabs). What I meant was my suggestion may have left extra empty lines as I did not account for the empty lines when highlighting. If there's no double empty lines then it's fine.

@GetLifty
Copy link
Copy Markdown
Contributor Author

8355cdc this isn't what I meant about whitespace. Please keep 4 space indentation (not tabs). What I meant was my suggestion may have left extra empty lines as I did not account for the empty lines when highlighting. If there's no double empty lines then it's fine.

Sorry, if you cant tell I am pretty new to github (and generally programming). My tired brain assumed that the indentation was causing the check failure and manually tried to fix it :(.

@GetLifty
Copy link
Copy Markdown
Contributor Author

Ok I reverted the commit (after spending embarrasingly long figuring out how). Still not 100% on the check failure but if its something I am missing feel free to let me know. Ive not got any more time to work today so I will likely fix this tommorow.

Copy link
Copy Markdown
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the failing action check.

Comment thread pterodactylnode.subdomain.conf.sample Outdated
@nemchik nemchik merged commit 7a4d827 into linuxserver:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants