Skip to content

Add http2 to all listen directives#576

Merged
nemchik merged 1 commit intomasterfrom
http2
May 31, 2023
Merged

Add http2 to all listen directives#576
nemchik merged 1 commit intomasterfrom
http2

Conversation

@nemchik
Copy link
Copy Markdown
Member

@nemchik nemchik commented May 31, 2023

Closes linuxserver/docker-swag#377

Specifics:

Existing confs are not causing broken instances, but are causing log warnings. The warning is stating that the protocols for the listen directive have been redefined after being set by another conf. Proxy confs did not previously include http2 because https://www.nginx.com/blog/http2-module-nginx/#QandA

Q: Will you support HTTP/2 on the upstream side as well, or only support HTTP/2 on the client side?

A: At the moment, we only support HTTP/2 on the client side. You can’t configure HTTP/2 with proxy_pass. [Editor – In the original version of this post, this sentence was incorrectly transcribed as “You can configure HTTP/2 with proxy_pass.” We apologize for any confusion this may have caused.]

But what is the point of HTTP/2 on the backend side? Because as you can see from the benchmarks, there’s not much benefit in HTTP/2 for low‑latency networks such as upstream connections.

Also, in NGINX you have the keepalive module, and you can configure a keepalive cache. The main performance benefit of HTTP/2 is to eliminate additional handshakes, but if you do that already with a keepalive cache, you don’t need HTTP/2 on the upstream side.

I still do not see any evidence that this has changed, but having the http2 directive does not cause issues (it might just be ignored).

Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik nemchik requested a review from a team May 31, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[warn] protocol options redefined for 0.0.0.0:443

2 participants