Conversation
0cac4e1 to
5a847cd
Compare
Contributor
Author
|
Tests are failing locally as well, the action is working fine. Once tests are fixed, this will be marked as ready for review. On a side note, we should probably set passing CI as mandatory in the repository settings, so we don't let regressions like this sneak in. |
73169c2 to
5d28a2c
Compare
5d28a2c to
6afe9f0
Compare
Contributor
Author
|
3 PRs later, tests pass. This is good to go. |
6afe9f0 to
f2153bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.