Mark a bunch of new tablets as having Dials and make the tests pass again#697
Merged
Conversation
The autogenerated code marked these as having strips but these have Dials. Change them accordingly. This patch may be incomplete, not all tablets model names can be found online.
For each device search for the corresponding .tablet file and if that file contains "autogenerated" allow for the dial/strip tests to fail (and skip the test with an error). This allows us to fix the SVGs one-by-one while leaving the upstream CI enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes a bunch of tablets from listed as having strips to having Dials. Manual search, I probably missed a few and a few others I couldn't find anything online about.
The second commit catches assertions in the strip/dial svg tests and converts them to
pytest.skip()for devices where the.tabletfile contains the string "autogenerated". This allows us to merge #687 and have the CI work properly again as well as fix the SVG files one-by-one.