Skip to content

Fix:IndexError raised from method Array.find #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linw1995 merged 3 commits into from
Sep 15, 2020
Merged

Fix:IndexError raised from method Array.find #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a06c8b7
Fix:IndexError raised from method Array.find
linw1995 Sep 15, 2020
34a90a4
New:Raise AssertionError if Array.idx is not valid
linw1995 Sep 15, 2020
586088a
Fix:f-strings debugging was implemented in Python 3.8 not 3.7
linw1995 Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions jsonpath/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import weakref

from abc import abstractmethod
from contextlib import suppress
from contextvars import ContextVar
from typing import (
Any,
Expand Down Expand Up @@ -455,16 +456,16 @@ def _get_partial_expression(self) -> str:
return f"[{self.idx!s}]"

def find(self, element: Any) -> List[Any]:
if self.idx is None and isinstance(element, list):
return element
elif (
isinstance(self.idx, int)
and isinstance(element, list)
and self.idx < len(element)
):
return [element[self.idx]]
elif isinstance(self.idx, Slice):
return self.idx.find(element)
if isinstance(element, list):
if self.idx is None:
return element
elif isinstance(self.idx, int):
with suppress(IndexError):
return [element[self.idx]]
elif isinstance(self.idx, Slice):
return self.idx.find(element)
else:
raise AssertionError(f"self.idx={self.idx!r} is not valid")

raise JSONPathFindError

Expand Down
4 changes: 4 additions & 0 deletions tests/test_lark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ def test_parse_check_and_extract(expression, data, expect):
("boo.*.boo", {"boo": {"boo": {"boo": 1}, "bar": {"bar": 2}}}, [1]),
("boo.*.boo", {"boo": {"boo": {"boo": 1}, "bar": 1}}, [1]),
("$[0]", [1, 2], [1]),
("$[1]", [1, 2], [2]),
("$[2]", [1, 2], []),
("$[-1]", [], []),
("$[-1]", [1], [1]),
("boo[0]", {"boo": [1, 2]}, [1]),
("$[*]", [1, 2], [1, 2]),
("$[:1]", [1, 2], [1]),
Expand Down