Skip to content

Commit 2aea3c7

Browse files
Wentao-Kuangblacha
andauthored
fix(server): Add lerc external into server package. (#3348)
### Motivation It looks like we are missing lerc in the server cli. https://github.com/linz/basemaps-config/actions/runs/11061552896/job/30734619452?pr=970 ![image](https://github.com/user-attachments/assets/fdbf96e6-1269-4904-9b7c-61463159929d) ### Modifications Add the `lerc` into server and cli package ### Verification Local build server container with lerc uninstall vs installed. #### UNINSTALL ![image](https://github.com/user-attachments/assets/5188a74f-14a3-4c34-88ee-9765e6bccbdf) #### INSTALLED ![image](https://github.com/user-attachments/assets/152ef321-6eca-4f6e-90ef-1fc603e2ce2a) #### Test Screenshot with fixed container ![image](https://github.com/user-attachments/assets/555d9ee3-5914-410d-bcf1-c337c6ab2a76) --------- Co-authored-by: Blayne Chard <bchard@linz.govt.nz>
1 parent 54032b2 commit 2aea3c7

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

package-lock.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cli/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
"outfile": "dist/index.cjs",
3131
"external": [
3232
"sharp",
33-
"pino-pretty"
33+
"pino-pretty",
34+
"lerc"
3435
]
3536
}
3637
],

packages/cli/src/cli/server/action.serve.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99

1010
const DefaultPort = 5000;
1111

12+
/** @deprecated 2024-09 Use the basemaps/server container directly now, and deprecate this later. */
1213
export class CommandServe extends CommandLineAction {
1314
config!: CommandLineStringParameter;
1415
assets!: CommandLineStringParameter;

packages/server/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
"executable": true,
3636
"external": [
3737
"pino-pretty",
38-
"sharp"
38+
"sharp",
39+
"lerc"
3940
]
4041
}
4142
],
@@ -47,7 +48,8 @@
4748
"@basemaps/landing": "^7.0.0"
4849
},
4950
"dependencies": {
50-
"sharp": "^0.33.0"
51+
"sharp": "^0.33.0",
52+
"lerc": "^4.0.4"
5153
},
5254
"devDependencies": {
5355
"@basemaps/config": "^7.7.0",

0 commit comments

Comments
 (0)