I have some improvements... #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add PANDOC_EXTENSIONS configuration variable, allowing one to enable or disable Pandoc's markdown extensions individually. * Remove dependency on pypandoc. * Don't change the working directory. * More efficient metadata extraction.
liob
added a commit
that referenced
this pull request
Dec 6, 2014
I very much like, what you have done with the code. I agree, that it is nice to be able to declare pandoc extensions. On the other hand, I disapproved at taking out pypandoc at first. However, after taking a closer look at the source of pypandoc, I came to realize, that in this case we do not hugely benefit by using an abstraction layer. Your code works nicely with my setup with the exception that you removed the change of the cwd. However, as pandoc_reader is still a very young project, I think we can afford to break compatibility. Thank you very much for your contribution!
Owner
|
I very much like, what you have done with the code. I agree, that it is nice to be able to declare pandoc extensions. On the other hand, I disapproved at taking out pypandoc at first. However, after taking a closer look at the source of pypandoc, I came to realize, that in this case we do not hugely benefit by using an abstraction layer. Your code works nicely with my setup with the exception that you removed the change of the cwd. However, as pandoc_reader is still a very young project, I think we can afford to break compatibility. Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable or disable Pandoc's markdown extensions individually.
The most important aspect of this is the
PANDOC_EXTENSIONSconfig variable. The only way to enable or disable extensions is to tack+whateveror-whateveron the end of the input format name; this can't be done with the existingPANDOC_ARGS.Unfortunately, pypandoc doesn't support this, so I just took it out -- it really wasn't doing much for us anyway.
The other changes are just tweakage. (Why did it seem necessary to change the working directory? As far as I can tell it is completely unnecessary.)