Ext 234 only show self accounts tokens and non#953
Merged
bradleySuira merged 4 commits intodevelopfrom Dec 7, 2022
Merged
Conversation
…ll router components / added lazy component for next tick improve render delay
…t swap filter to have same address
bradleySuira
requested review from
AndonMitev,
Jennievon,
beemi,
kraikov,
monokh,
skeremidchiev and
tima-t
as code owners
EXT-234 Only show self account's tokens and non-EVM chains in the switcher inside the Swap screen (multi-account)
At this time providers don't support token swaps to a different address than the source address itself. DOD: Don't show other EVM accounts (Multi-Account) in the token selector inside the Swap screen that does not match the same Account's address. |
mpwanyi256
approved these changes
Dec 7, 2022
Contributor
mpwanyi256
left a comment
mpwanyi256
left a comment
There was a problem hiding this comment.
@bradleySuira CODE LGTM 🔥
Kudos on the routes import refactor
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
🔍 Ready for Review
bradleySuira
deleted the
ext-234-only-show-self-accounts-tokens-and-non
branch
trafico-bot
bot
added
✨ Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Linear Ticket 📚 #ext-234
This PR includes:
dev:toolsinside package.json