Skip to content

Ext 253/gas fee handler#980

Merged
bradleySuira merged 4 commits intodevelopfrom
ext-253/gas-fee-handler
Jan 13, 2023
Merged

Ext 253/gas fee handler#980
bradleySuira merged 4 commits intodevelopfrom
ext-253/gas-fee-handler

Conversation

@mpwanyi256
Copy link
Contributor

📚 Linear Ticket 📚

@linear
Copy link

linear bot commented Jan 13, 2023

EXT-253 If user does not have enough native coin for gas fee message at top should appear

If user does not have enough native coin for gas fee message at top should appear and user should not be able to continue with the token send.

User is allowed to continue despite no having enough for gas fee:

no_top.png

This is how it looks on swaps with insufficient native coin for swap. User is unable to continue.

top.png

We should not ket the user continue to review, they hit this error message shown below if they do:

Gas required exceeds allowance error does not have friendly message

If user doesn't have enough native coin to pay the gas transaction fees of an ERC20 token send and error is hit and no friendly error message is shown, just the generic one.

Actual error:

gas required exceeds allowance (20568)

message (2).txt

matic_ins.png

matic_insu.png

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 13, 2023
Copy link
Member

@bradleySuira bradleySuira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just take in account the prettyBalance comment

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jan 13, 2023
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ✅ Approved Pull Request has been approved and can be merged labels Jan 13, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 13, 2023
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jan 13, 2023
@bradleySuira bradleySuira merged commit 0c9c126 into develop Jan 13, 2023
@bradleySuira bradleySuira deleted the ext-253/gas-fee-handler branch January 13, 2023 15:08
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Merged Pull Request has been merged successfully size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants