Propagate Expressions#215
Merged
Merged
Conversation
rcosta358
added
enhancement
CatarinaGamboa
approved these changes
May 11, 2026
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Minor changes.
For you thesis, you should plan to write a pseudo-code algorithm of how simplification of expressions works with all the steps and additions you have been making.
| return null; | ||
|
|
||
| int signedLeft = "+".equals(leftBinary.getOperator()) ? leftLiteral.getValue() : -leftLiteral.getValue(); | ||
| int signedRight = "+".equals(op) ? rightLiteral.getValue() : -rightLiteral.getValue(); |
Collaborator
There was a problem hiding this comment.
overflows? maybe just an if checking its fine
Collaborator
Author
There was a problem hiding this comment.
Good catch. I think that can happen in more places, not just here. Will fix it in a follow-up PR.
| return null; | ||
| if (!(rightNode.getValue()instanceof LiteralInt rightLiteral)) | ||
| return null; | ||
| if (!(leftNode.getValue()instanceof BinaryExpression leftBinary)) |
Collaborator
There was a problem hiding this comment.
nit spacee between method and instanceof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the propagation of expressions, instead of only literals or other variables.
With this, we can propagate all the following:
var == literal,var == var, and nowvar == expression.For example, the assignment
x == y + 1now adds the mappingx → y + 1, allowing the RHS to be propagated whereverxappears.Example
Before
After
Related Issue
None.
Type of change
Checklist
ExpressionSimplifierTestmvn testpasses locally