Skip to content

Fix External Method Not Found #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 2 commits into from
May 18, 2026
Merged

Fix External Method Not Found #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
904fd0b
Fix External Method Not Found
rcosta358 May 18, 2026
706b099
Minor Changes
rcosta358 May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...verifier/src/main/java/liquidjava/diagnostics/warnings/ExternalMethodNotFoundWarning.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@
*/
public class ExternalMethodNotFoundWarning extends LJWarning {

private final String methodName;
private final String signature;
private final String className;
private final String[] overloads;

public ExternalMethodNotFoundWarning(SourcePosition position, String message, String methodName, String className,
public ExternalMethodNotFoundWarning(SourcePosition position, String message, String signature, String className,
String[] overloads) {
super(message, position);
this.methodName = methodName;
this.signature = signature;
this.className = className;
this.overloads = overloads;
}

public String getMethodName() {
return methodName;
public String getSignature() {
return signature;
}

public String getClassName() {
Expand Down
14 changes: 7 additions & 7 deletions .../src/main/java/liquidjava/processor/refinement_checker/ExternalRefinementTypeChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,19 @@ public <R> void visitCtMethod(CtMethod<R> method) {
boolean isConstructor = method.getSimpleName().equals(targetType.getSimpleName());
if (isConstructor) {
if (!constructorExists(targetType, method)) {
String message = String.format("Could not find constructor '%s' for '%s'", method.getSignature(),
prefix);
String signature = method.getSignature();
String message = String.format("Could not find constructor '%s' for '%s'", signature, prefix);
String[] overloads = getOverloads(targetType, method);
diagnostics.add(new ExternalMethodNotFoundWarning(method.getPosition(), message, method.getSignature(),
diagnostics.add(new ExternalMethodNotFoundWarning(method.getPosition(), message, signature,
prefix, overloads));
}
} else {
if (!methodExists(targetType, method)) {
String message = String.format("Could not find method '%s %s' for '%s'",
method.getType().getSimpleName(), method.getSignature(), prefix);
String signature = String.format("%s %s", method.getType().getSimpleName(), method.getSignature());
String message = String.format("Could not find method '%s' for '%s'", signature, prefix);
String[] overloads = getOverloads(targetType, method);
diagnostics.add(new ExternalMethodNotFoundWarning(method.getPosition(), message, method.getSignature(),
prefix, overloads));
diagnostics.add(
new ExternalMethodNotFoundWarning(method.getPosition(), message, signature, prefix, overloads));
return;
}
}
Expand Down
Loading