Skip to content

Add Counterexamples #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 1 commit into from
Feb 23, 2026
Merged

Add Counterexamples #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified client/server/language-server-liquidjava.jar
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions client/src/types/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export type RefinementError = BaseDiagnostic & {
expected: ValDerivationNode;
found: ValDerivationNode;
customMessage: string;
counterexample: string;
}

export type StateConflictError = BaseDiagnostic & {
Expand Down
1 change: 1 addition & 0 deletions client/src/webview/views/verification/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const errorContentRenderers: Partial<Record<LJError['type'], (error: LJError) =>
${e.customMessage ? renderSection('Message', e.customMessage) : ''}
${renderSection('Expected', e.expected.value)}
${renderCustomSection('Found', renderDerivationNode(e, e.found))}
${e.counterexample ? renderSection('Counterexample', e.counterexample) : ''}
`,
'state-refinement-error': (e: StateRefinementError) => /*html*/`
${e.customMessage ? renderSection('Message', e.customMessage) : ''}
Expand Down
2 changes: 1 addition & 1 deletion server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
<dependency>
<groupId>io.github.liquid-java</groupId>
<artifactId>liquidjava-verifier</artifactId>
<version>0.0.12</version>
<version>0.0.14</version>
</dependency>
<dependency>
<groupId>tools.aqua</groupId>
Expand Down
4 changes: 2 additions & 2 deletions server/src/main/java/dtos/errors/RefinementErrorDTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
* DTO for serializing RefinementError instances to JSON
*/
public record RefinementErrorDTO(String category, String type, String title, String message, String file, ErrorPosition position,
TranslationTableDTO translationTable, ValDerivationNode expected, ValDerivationNode found, String customMessage) {
TranslationTableDTO translationTable, ValDerivationNode expected, ValDerivationNode found, String customMessage, String counterexample) {

public static RefinementErrorDTO from(RefinementError error) {
return new RefinementErrorDTO("error", "refinement-error", error.getTitle(), error.getMessage(), error.getFile(),
error.getPosition(), TranslationTableDTO.from(error.getTranslationTable()), error.getExpected(), error.getFound(), error.getCustomMessage());
error.getPosition(), TranslationTableDTO.from(error.getTranslationTable()), error.getExpected(), error.getFound(), error.getCustomMessage(), error.getCounterExampleString());
}
}