Add neighbors_method and eigen_method params to bindings#120
Merged
Conversation
…ndings Allow users to control neighbor search strategy (brute, vptree, covertree) and eigendecomposition method (dense, randomized, arpack) from both Python and R interfaces. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…params The auto-generated RcppExports.R and RcppExports.cpp were not regenerated after adding the new parameters, causing "unused arguments" error at package load time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add R tests for brute/vptree neighbors and dense/randomized eigen methods, plus error cases for unknown values. Add matching Python tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
neighbors_methodparameter to Python and R bindings to control neighbor search strategy (brute,vptree,covertree)eigen_methodparameter to Python and R bindings to control eigendecomposition method (dense,randomized,arpack)Test plan
neighbors_methodandeigen_methodargumentsneighbors_methodandeigen_methodarguments🤖 Generated with Claude Code