Deep copy auth.users to prevent infinite loop#2020
Merged
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: Bugfix
Overview
OIDC auth was causing an infinite Vue render loop that spiked CPU/RAM until the browser crashed.
Because
getUsers()in Auth.js grabbed a direct reference to the auth.users array in the Vuex store, then.push()'d the OIDC user onto it. But since Vue 2 intercepts array mutations like push for reactivity, every call to getUsers() during a render was re-triggering another render, which calledgetUsers()again and again.Fixed by just doing a deep copy, so the push only hits a local copy, and store is never mutated.
Issue Number #1995
New Vars N/A
Screenshot N/A