i18n: drop orphaned keys from locale files#2131
Merged
Merged
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Three keys remained in locale JSON files after their corresponding English source was removed by upstream: • interactive-editor.export.view-title — 25 locales • app-info.support-dashy — 14 locales • app-info.support-dashy-description — 14 locales `grep -r` against the source confirms zero references in any .vue / .js / .ts file. They've been dead translation keys ever since: • b84a9b5 "Adds debug view, removes about page" (about-page support copy) • 030fa96 "Adds new config view/export menu" (export view title) Pure removal — no behavioural change. Net: 25 files, -53 keys.
synack1337
force-pushed
the
orphan-i18n-cleanup
branch
from
499bfde to
57a618e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Localization
Overview
Removes three orphaned i18n keys from locale JSON files. Their
corresponding English source was removed by upstream a couple of weeks
ago, but the locale files were never cleaned up so the keys lingered as
dead translations.
interactive-editor.export.view-titleapp-info.support-dashyapp-info.support-dashy-descriptiongrep -ragainst the source confirms zero references in any.vue/.js/.tsfile. The keys have been dead since:b84a9b5Adds debug view, removes about page — removed the about page that referencedsupport-dashy*030fa96Adds new config view/export menu — restructured the export view, removedview-titlePure removal, no behavioural change. 25 files, −53 keys net.