Skip to content

Conversation

@MarkJamesHoward
Copy link
Contributor

@MarkJamesHoward MarkJamesHoward commented Sep 16, 2018

In the Declarative Rendering section of README.md it seems to be using lit-html syntax rather than how we use properties in LitElement where we'd need to specify the 'this' keyword?

So rather than:

class="${color} special"

we should have

class="${this.color} special"

Reference Issue

Fixes #197

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@MarkJamesHoward
Copy link
Contributor Author

CLA signed

@sorvell
Copy link
Member

sorvell commented Sep 17, 2018

Thanks for the PR. Can you please verify that the CLA is signed? The bot is still complaining.

@MarkJamesHoward
Copy link
Contributor Author

Ah sorry different email on my google account and Github - I've used the Github email to sign the CLA now. Hopefully it goes green :-)

@googlebot
Copy link

CLAs look good, thanks!

@justinfagnani justinfagnani merged commit 996f509 into lit:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants