Skip to content

[docs] Code samples for accessors with subclassing && tidy up doc #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
5 commits merged into from
Feb 4, 2019
Merged

[docs] Code samples for accessors with subclassing && tidy up doc #489

5 commits merged into from
Feb 4, 2019

Conversation

@ghost
Copy link

@ghost ghost commented Jan 28, 2019 •
edited by ghost
Loading

Edits to Kevin's PR for no-wrap-accessor-docs

@ghost ghost requested a review from justinfagnani as a code owner January 28, 2019 20:54
justinfagnani
justinfagnani requested changes Jan 29, 2019
View reviewed changes
justinfagnani and others added 3 commits January 29, 2019 16:09
@justinfagnani
Update docs/_guide/properties.md
a201bfe 
Co-Authored-By: katejeffreys <katejeffreys@google.com>
@justinfagnani
Update docs/_guide/properties.md
5cb2d13 
Co-Authored-By: katejeffreys <katejeffreys@google.com>
Feedback
b1a5ead
@ghost ghost changed the title Code samples for accessors with subclassing [docs] Code samples for accessors with subclassing && tidy up doc Jan 29, 2019
@ghost ghost requested a review from kevinpschaaf January 29, 2019 21:37
@ghost ghost mentioned this pull request Jan 29, 2019
Merged
kevinpschaaf
kevinpschaaf requested changes Jan 30, 2019
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prose changes look great. Minor code suggestions.

@ghost
Copy link
Author

ghost commented Feb 4, 2019

Ready for another look @kevinpschaaf @justinfagnani

Staged: https://20190204t115009-dot-polymer-lit-element.appspot.com

kevinpschaaf
kevinpschaaf approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, much cleaner.

@justinfagnani
Copy link
Contributor

justinfagnani commented Feb 4, 2019

Comment on existing text. This: https://github.com/Polymer/lit-element/pull/489/files#diff-f37c02b7dd321fd8fca26553760681d7R16

Is a little vague. I'm not sure a reader unfamiliar with upgrades and this issue already will know what that's talking about. Maybe file an issue to clean up?

@ghost
Copy link
Author

ghost commented Feb 4, 2019

Comment on existing text. This: https://github.com/Polymer/lit-element/pull/489/files#diff-f37c02b7dd321fd8fca26553760681d7R16

Is a little vague. I'm not sure a reader unfamiliar with upgrades and this issue already will know what that's talking about. Maybe file an issue to clean up?

#528

@ghost ghost merged commit 92e7907 into no-wrap-accessor-docs Feb 4, 2019
@ghost ghost deleted the no-wrap-accessor-docs-2 branch March 25, 2019 19:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfagnani @kevinpschaaf @googlebot