Ensure attribute reflected from property is correct #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #592. Ensures a reflecting property set immediately after a corresponding attribute reflects correctly.
kevinpschaaf
approved these changes
Mar 13, 2019
| const ctor = this.constructor as typeof UpdatingElement; | ||
| const options = | ||
| ctor._classProperties!.get(name) || defaultPropertyDeclaration; | ||
| if (ctor._valueHasChanged( |
Member
There was a problem hiding this comment.
Unrelated to PR, but why do we pass options.hasChanged through a static method that just calls it? It's private so it can't be overridden by user...
Member
Author
There was a problem hiding this comment.
I believe we intend to make this overridable at some point.
justinfagnani
approved these changes
Mar 13, 2019
src/lib/updating-element.ts
Outdated
| // track old value when changing. | ||
| this._changedProperties.set(name, oldValue); | ||
| // add to reflecting properties set | ||
| // Track old value when changing. |
Contributor
There was a problem hiding this comment.
nit: This reads more like a "what" comment than a "why". It'd be nice to either say why we only record the once, or remove the comment since the code seems pretty self-documenting on what it's doing.
src/lib/updating-element.ts
Outdated
| this._reflectingProperties.set(name, options); | ||
| } | ||
| // abort the request if the property should not be considered changed. | ||
| // Abort the request if the property should not be considered changed. |
Contributor
There was a problem hiding this comment.
what line is this commenting? The last line of the if case or the else case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592. Ensures a reflecting property set immediately after a corresponding attribute reflects correctly.