Skip to content

Add extra type information to help closure with type of static property. #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2020
Merged

Add extra type information to help closure with type of static property. #923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c19e452
Add extra type information to help closure with type of static property.
kevinpschaaf Mar 14, 2020
eb286a2
Add tslint:disable for "unnecessary" type assertion necessary for clo…
kevinpschaaf Mar 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/updating-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,10 @@ export abstract class UpdatingElement extends HTMLElement {
return;
}
const ctor = (this.constructor as typeof UpdatingElement);
const propName = ctor._attributeToPropertyMap.get(name);
// Note, hint this as an `AttributeMap` so closure clearly understands
// the type; it has issues with tracking types through statics
// tslint:disable-next-line:no-unnecessary-type-assertion
const propName = (ctor._attributeToPropertyMap as AttributeMap).get(name);
if (propName !== undefined) {
const options = ctor.getPropertyOptions(propName);
// mark state reflecting
Expand Down