Constrain frame-src CSP to only allow the playground and youtube embeds #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL(s) below. https://pr528-7c13f2d---lit-dev-5ftespv5na-uc.a.run.app/ |
aomarks
force-pushed
the
csp-frame-src
branch
from
ed0d0d9 to
e3adbf2
Compare
AndrewJakubowicz
approved these changes
Sep 29, 2021
Contributor
AndrewJakubowicz
left a comment
AndrewJakubowicz
left a comment
There was a problem hiding this comment.
I manually checked some references and ran locally. Not sure that running this locally exercises the changes though.
| // In dev mode, http: is needed for http://localhost Playground iframes. | ||
| `frame-src https:${opts.devMode ? ' http:' : ''}`, | ||
| // Playground previews and embedded YouTube videos. | ||
| `frame-src ${opts.playgroundPreviewOrigin} https://www.youtube-nocookie.com/`, |
Contributor
There was a problem hiding this comment.
TIL: youtube-nocookie
aomarks
force-pushed
the
csp-remove-unsafe-inline
branch
from
24e9c6f to
0b7b3dd
Compare
aomarks
force-pushed
the
csp-frame-src
branch
from
df494bb to
e248987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #517