[tutorials] svg tutorial updates #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL(s) below. https://pr826-85b3260---lit-dev-5ftespv5na-uc.a.run.app/ |
AndrewJakubowicz
approved these changes
May 11, 2022
Contributor
AndrewJakubowicz
left a comment
AndrewJakubowicz
left a comment
There was a problem hiding this comment.
The preview url is a bit hard to review because the branch is based off a stale main - prior to the other great fixes and tutorials being released.
Changes LGTM! Great stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects demo colors in the initial page of the tutorial. The color pickers did not match the colors rendered by the demo.
This PR removes instances of shortened color hexes like
#fff. SVG has a rough time with them (sometimes errors).