Skip to content

[tutorials] svg tutorial updates #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2022
Merged

[tutorials] svg tutorial updates #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85b3260
correct demo colors, remove rect in tutorial
taylor-vann May 10, 2022
91e0410
consistent colors through tutorial sections
taylor-vann May 10, 2022
d829362
remove mention of rect styling
taylor-vann May 10, 2022
85249dc
consistent colors in examples
taylor-vann May 10, 2022
f91b2ef
Merge branch 'main' into svg-tutorial
taylor-vann May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lit-dev-content/samples/tutorials/svg-templates/00/before/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@
<input value="T">
<input type="range" min="2" max="29" value="8">
<input type="range" min="0" max="360" value="0">
<input type="color" value="#000000">
<input type="color" value="#7acbf1">
<input type="color" value="#e3a7b2">
<input type="color" value="#ffffff">
</div>
</body>
Expand Down
2 changes: 1 addition & 1 deletion packages/lit-dev-content/site/tutorials/content/svg-templates/03.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const helloTile = svg`
clip-path="url(#rect-clip)"
width="300"
height="300"
fill="#000">
fill="#000000">
</rect>
```

Expand Down
2 changes: 1 addition & 1 deletion packages/lit-dev-content/site/tutorials/content/svg-templates/04.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ render() {
return html`
<svg height="100%" width="100%">
...
<rect height="100%" width="100%" fill="#fff"></rect>
<rect height="100%" width="100%" fill="#ffffff"></rect>
<rect height="100%" width="100%" fill="url(#repeat-pattern)"></rect>
</svg>
`;
Expand Down
26 changes: 10 additions & 16 deletions packages/lit-dev-content/site/tutorials/content/svg-templates/05.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,13 @@ CSS applies attributes to HTML.
However, only [SVG presentation attributes](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/Presentation)
can be applied to SVG through CSS.

In the following example, all `<rect>` elements will be as wide as
their parent element while elements using the class `background` will
In the following example, all elements using the class `background` will
have a black fill.


```ts
const helloSvgCss = css`
rect {
width: 100%;
}

.background {
fill: #000;
fill: #000000;
}
`;
```
Expand All @@ -44,7 +38,7 @@ HTML counterpart.
```ts
const helloCssCustomProperties = css`
.background {
fill: var(--background-color, #ff8800);
fill: var(--background-color, #000000);
}
`;
```
Expand All @@ -68,7 +62,7 @@ const svgCSS = css`
}

text {
fill: #fff;
fill: #ffffff;
dominant-baseline: hanging;
font-family: monospace;
font-size: 24px;
Expand All @@ -90,14 +84,14 @@ representing the required theme.
```ts
const themeCSS = css`
.background {
fill: var(--background-color, #000);
fill: var(--background-color, #000000);
}

text {
fill: var(--font-color, #fff);
fill: var(--font-color, #ffffff);
font-size: var(--font-size, 26px);
stroke-width: var(--stroke-width, 1.2px);
stroke: var(--stroke-color, #eee);
stroke: var(--stroke-color, #eeeeee);
}
`;
```
Expand Down Expand Up @@ -147,11 +141,11 @@ Finally add CSS custom properties to the styles in `index.html` to theme

```css
:root {
--background-color: #000;
--font-color: #fff;
--background-color: #000000;
--font-color: #ffffff;
--font-size: 26px;
--stroke-width: 1.2px;
--stroke-color: #7acbf1;
--stroke-color: #eeeeee;

font-family: 'Open Sans', sans-serif;
font-size: 1.5em;
Expand Down