Skip to content

mbs can now handle units#123

Merged
ziotom78 merged 2 commits intomasterfrom
mbs_units
Sep 20, 2021
Merged

mbs can now handle units#123
ziotom78 merged 2 commits intomasterfrom
mbs_units

Conversation

@NicolettaK
Copy link
Copy Markdown
Contributor

This PR modifies the Mbs module in order to:

  • handle output units
  • make K_CMB as default units
  • do not generate FG maps when make_fg = False, even if fg_model is defined

@NicolettaK NicolettaK mentioned this pull request Jul 8, 2021
@paganol
Copy link
Copy Markdown
Member

paganol commented Sep 19, 2021

Ciao @NicolettaK, can we merge this?

@ziotom78
Copy link
Copy Markdown
Member

Hi @paganol, the code should be ok, but I waited before merging it because the modifications were not documented. It should be trivial to do so (just add a couple of sentences), I'll have a look.

@ziotom78
Copy link
Copy Markdown
Member

I have had a look at the patch and decided that the change in the docstring should be enough. It would have been nice to extend a bit the short example at the beginning of chapter «Synthetic sky maps» in the User's Manual, but for the moment let's be satisfied with this.

@ziotom78 ziotom78 merged commit 3072700 into master Sep 20, 2021
@ziotom78 ziotom78 deleted the mbs_units branch September 20, 2021 09:49
@ziotom78 ziotom78 restored the mbs_units branch September 20, 2021 09:51
ziotom78 added a commit that referenced this pull request Sep 20, 2021
@ziotom78 ziotom78 deleted the mbs_units branch April 12, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants