Skip to content

Perform a critical update of NumPy and update Numba and Rich#152

Merged
ziotom78 merged 2 commits intomasterfrom
numpy_dep
Jan 14, 2022
Merged

Perform a critical update of NumPy and update Numba and Rich#152
ziotom78 merged 2 commits intomasterfrom
numpy_dep

Conversation

@ziotom78
Copy link
Copy Markdown
Member

Dependabot discovered that we depend on a NumPy version (1.20.3) that has a critical bug:

https://github.com/litebird/litebird_sim/security/dependabot/poetry.lock/numpy/open/update-logs/172230966

In this PR I have updated NumPy to 1.21. This required to upgrade Numba from 0.54 to 0.55.

I updated Rich from version 6.2 (old!) to version 11.0.

@ziotom78 ziotom78 merged commit 734f581 into master Jan 14, 2022
@ziotom78 ziotom78 deleted the numpy_dep branch January 14, 2022 10:45
ziotom78 added a commit that referenced this pull request Jan 14, 2022
@mreineck
Copy link
Copy Markdown
Collaborator

Hi @ziotom78 , the link above gives a 404 for me ... do you have another link describing the numpy bug perhaps? (I'd like to check whether I have to update my own package dependencies ...)

@ziotom78
Copy link
Copy Markdown
Member Author

Mmm… Unfortunately the link disappeared, I don't know what happened but the page with Dependabot «closed» issues is empty:

https://github.com/litebird/litebird_sim/security/dependabot

When I accepted the warning, I was assuming that it was related to the big yellow warning at the top of the 1.21 release page:

There are unresolved problems compiling NumPy 1.20.0 with gcc-11.1.

  • Optimization level -O3 results in many incorrect warnings when running the tests.

  • On some hardware NumPY will hang in an infinite loop.

@mreineck
Copy link
Copy Markdown
Collaborator

Ah, I see, thanks!

OK, that only seems to be an issue for people who compile their own numpy and use a specific compiler. Probably not a big reason to worry for us, but updating the requirement to 1.21 certainly won't hurt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants