Typos, test and some documentation

[paganol]

This PR corrects a typo in make_bin_map, improves the test test_mapping.py, and adds some documentation.
It also improves add_dipole_to_observations, now if pointings is not provided it can be retrieved from Observation.pointings

[sgiardie]

Hi @ziotom78, I added this small piece here to handle obs.start_time passed as an astropy.time.Time object. In this case, obs.start_time is not a number and we have to call obs.start_time.cxcsec

[ziotom78]

Good catch @sgiardie , this is absolutely correct!

[paganol]

Hi @ziotom78, we changed a bit the destriper, now it retrives the pointing from the observations (or pointings can be passed as optional argument). The previous version failed with a rotating hwp. If you like the last changes we can merge and release 0.5.0. I think @sgiardie has also an example notebook ready.

[sgiardie]

Hi @ziotom78 and @paganol, I did some small changes in destriper/__init__.py to solve some errors due to the shape of sim.observations and pointings. I also added the notebook I have been working on. Now the binned map from make_bin_map and the one coming from MADAM seem to agree quite well, instead the destriped map is a bit weird. I plotted that in the notebook, if you can give a look at it you can tell me what is wrong and what should I change

[sgiardie]

I reverted the changes in destriper/__init__.py, since the errors I was having depended on not passing pointings as a list of pointings corresponding to each sim.observations. I should have done

pointings=[]
for obs in sim.observations:
    pointings.append(lbs.get_pointings(obs,
                      spin2ecliptic_quats=sim.spin2ecliptic_quats,
                      detector_quats = None,
                      bore2spin_quat=instr.bore2spin_quat,
                      hwp=lbs.hwp.IdealHWP(hwp_radpsec),
                     ))

as I am doing now.
The notebook is corrected accordingly, but of course the issue in the destriped maps is still there

[sgiardie]

Hi @ziotom78, I removed the destriper examples from the notebook. You may want to reformat it again, though. I was not able to do that

[ziotom78]

Hi Serena, I checked and the code looks ok, black does not need to change it. You can merge it, thanks!