Conversation
…im into hwp_doc_and_pointing
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues described in #197.
I made the following changes:
get_pointings, the parameterdetector_quatsbecame optional. Now, not passing this parameter, the function takes detector quaternions from the observation passed.get_pointings_for_observations, which wrapsget_pointings. Now you can pass a list of observations to this function and a list of pointings is returned. This function provides a nice shortcut with a simplified interface with fewer options. Of course, for a more refined simulation,get_pointingsmust be used. The logic is the same we used inadd_noise_to_observations,scan_map_in_observations, etc...HWPclass withget_pointings.