Skip to content

hwp doc and change in get_pointing#198

Merged
paganol merged 26 commits intomasterfrom
hwp_doc_and_pointing
Sep 21, 2022
Merged

hwp doc and change in get_pointing#198
paganol merged 26 commits intomasterfrom
hwp_doc_and_pointing

Conversation

@paganol
Copy link
Copy Markdown
Member

@paganol paganol commented Sep 20, 2022

This PR addresses the issues described in #197.
I made the following changes:

  • In get_pointings, the parameter detector_quats became optional. Now, not passing this parameter, the function takes detector quaternions from the observation passed.
  • A new function was created, called get_pointings_for_observations, which wraps get_pointings. Now you can pass a list of observations to this function and a list of pointings is returned. This function provides a nice shortcut with a simplified interface with fewer options. Of course, for a more refined simulation, get_pointings must be used. The logic is the same we used in add_noise_to_observations, scan_map_in_observations, etc...
  • Relevant tests were also fixed and they all pass on my laptop. On GitHub, they fail, but it seems to be a problem not related to my commits.
  • The documentation is fixed accordingly. I also added a small extra entry in the section Scanning strategy for describing how to use the HWP class with get_pointings.

@paganol paganol linked an issue Sep 20, 2022 that may be closed by this pull request
@ziotom78
Copy link
Copy Markdown
Member

@paganol , sorry for the mess, I mistakenly merged #160 here and had to revert it. Now the CI builds pass, this PR can be merged.

@paganol paganol merged commit 5fb2b89 into master Sep 21, 2022
@paganol paganol deleted the hwp_doc_and_pointing branch September 21, 2022 12:16
@paganol paganol mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for hwp.py

2 participants