Fix MPI crash in Observation when allocate_tod=False#491
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeErrorthat occurs when initializing anObservationwithallocate_tod=Falsein an MPI environment.When
allocate_todis set toFalse, the Time-Ordered Data (TOD) attributes (e.g., self.tod) are initialized as None. However, theObservation.__init__method immediately callssetattr_det_globalto synchronize detector metadata. Insidesetattr_det_global, an assertion attempts to verify the length of the incoming metadata against the length of the TOD array usinglen().Because
len(None)is an invalid operation, the simulation crashes during the observation creation phase.Changes:
litebird_sim/observations.py: Modifiedsetattr_det_globalto check if the TOD attribute isNonebefore attempting to validate its length.Added a conditional check: the assertion is now only executed if
tod_listis present and the corresponding TOD attribute has been allocated.