Conversation
The angle passed to `add_2f_for_one_detector` allocated a temporary object that garbles memory with Numba 0.63. The new code does no longer use `parallel=True`, but it avoids an allocation and works under Python 3.14 + Numba 0.63.
I added a few more comments and used more explicit IMo paths
So far PySM3 does not support NumPy 2, so we better wait
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, this PR aimed to introduce support for Python 3.14 as well as update some dependencies (Ducc, Numba, NumPy). However:
So for the moment we keep supporting Python 3.10–3.13. I have upgraded Ducc to 0.40 and Numba to 0.63.
In trying to circumvent the problems with Numpy 1.26 and Python 3.14, I managed to save some memory in the HWP code by modifying the API of
compute_2f_for_one_sample.