Skip to content

Bin map maker#73

Merged
ziotom78 merged 4 commits intomasterfrom
bin_map_maker
Nov 12, 2020
Merged

Bin map maker#73
ziotom78 merged 4 commits intomasterfrom
bin_map_maker

Conversation

@dpole
Copy link
Copy Markdown
Member

@dpole dpole commented Oct 28, 2020

Purpose of this PR is to provide a minimal mapping tool, while more sophisticated procedures will be probably delegated to specialized libraries.

  • binning tool
  • diagonal pixel covariance
  • correction for the pixel covariance
  • handle multiple maps
  • MPI parallel

@dpole
Copy link
Copy Markdown
Member Author

dpole commented Nov 10, 2020

Distributed Observations are now handled. Note that currently all the detectors in an observation are mapped to the same map.

I think this is enough for a first merge, even though new functionalities may break the API. These may include

  • mapping different set of detectors in the Observations to different maps
  • return also the covariance map

@dpole
Copy link
Copy Markdown
Member Author

dpole commented Nov 12, 2020

Some tests have failed, but they are install issues. Shall we force merge?

@ziotom78 ziotom78 merged commit eade347 into master Nov 12, 2020
@ziotom78
Copy link
Copy Markdown
Member

Merged! @dpole, might you please update the CHANGELOG with a reference to this PR?

@dpole
Copy link
Copy Markdown
Member Author

dpole commented Nov 12, 2020

Sure. I could have done before merging

@dpole
Copy link
Copy Markdown
Member Author

dpole commented Nov 12, 2020

Done

@ziotom78 ziotom78 deleted the bin_map_maker branch January 9, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants