Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/REVIEW_GUIDELINES.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
# Review Guidelines — agentkeys

This is the single source of truth for code review patterns in this repo. The
`claude-code-review.yml` workflow points Claude at this file; human reviewers
should also use it as a checklist.
[`claude-code-review.yml`](workflows/claude-code-review.yml) workflow points
Claude at this file on PR *submission* events (`opened`, `ready_for_review`,
`reopened`) — NOT on every push, to cap token cost. Human reviewers should
use it as a checklist, and `@claude`-invoked reviews
(see [`claude.yml`](workflows/claude.yml)) pick it up when relevant.

Background: these patterns were distilled from 15+ PR review cycles in
March-April 2026 where codex repeatedly surfaced the same classes of bug. Each
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/claude-code-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,14 @@ name: Claude Code Review

on:
pull_request:
types: [opened, synchronize, ready_for_review, reopened]
# Run only on PR submission events — NOT on every push (`synchronize`).
# `opened` — first PR submission
# `ready_for_review` — draft promoted to ready (effectively a submission)
# `reopened` — closed PR reopened
# Subsequent pushes to the PR branch are intentionally NOT reviewed, to
# cap Claude usage cost. Re-trigger manually by closing + reopening the
# PR, or by `@claude review` mention (handled in claude.yml).
types: [opened, ready_for_review, reopened]
# Run only on paths that contain real code or CI config.
# Pure docs pushes (`docs/**`, including `docs/wiki/**`) don't need a full code review
# — they go through normal PR approval. This also skips Cargo.lock-only
Expand Down
Loading