Skip to content

Conversation

@BillyWooo
Copy link
Collaborator

mainly focus on: build release version omni-executor with gramine.
There was a test release: https://hub.docker.com/layers/litentry/omni-executor/v0.9.25-01/images/sha256-167e5994a871ac8693fc790eb14bcacc977168dee2406c48ac19b27e5dc3d907

@BillyWooo BillyWooo requested a review from a team April 7, 2025 12:33
@BillyWooo BillyWooo self-assigned this Apr 7, 2025
@linear
Copy link

linear bot commented Apr 7, 2025

@kziemianek
Copy link
Member

@BillyWooo Could you please adjust file-filters / ci job so it rebuilds omni-executor docker image when definition changes ?
Then it should fail -> because for CI and local docker compose we need old definition (non sgx)

@kziemianek
Copy link
Member

@BillyWooo Could you please adjust file-filters / ci job so it rebuilds omni-executor docker image when definition changes ? Then it should fail -> because for CI and local docker compose we need old definition (non sgx)

Nvm - I missed target specified in make build-docker 👍🏼

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - do you have the docker running script? Especially about the mounting?

# WORKDIR $EXECUT_DIR
ENV HOME=/home/ubuntu
ENV BUILD_DIR=$HOME/tee-worker/omni-executor
ENV EXECUT_DIR=/usr/local/bin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean EXECUTOR_DIR, or BIN_DIR?

@BillyWooo
Copy link
Collaborator Author

Thank you - do you have the docker running script? Especially about the mounting?

Yes. In our devops repo. That needs to adjust parameter and test again.

@BillyWooo BillyWooo merged commit 47449d9 into dev Apr 8, 2025
3 checks passed
@BillyWooo BillyWooo deleted the p-1398-config-and-cicd-of-omni-executor branch April 8, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants