-
Notifications
You must be signed in to change notification settings - Fork 18
Simplify rpc response and error handling for OE #3803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job PR Review: Simplify RPC Response and Error Handling
|
kziemianek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left small comments. This is a good code improvement.
tee-worker/omni-executor/rpc-server/src/methods/omni/export_bundler_private_key.rs
Outdated
Show resolved
Hide resolved
| "Authentication verification failed" | ||
| ).with_suggestion("Please check your authentication credentials")) | ||
| })?; | ||
| debug!("Received omni_exportWallet, params: {:?}", params); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe middleware could be used for that

Context
This is a big refactoring to the current response and error handling implementation:
PumpxRpcErrorcompletely and useDetailedErrorinstead as the only wrappererror_code.rsdetailed_error.rs,RpcResultExt,RpcOptionExt,extract_omni_account,parse_as,parse_rpc_params... etcAs result, more than 2000 LoC can be removed:
I think some places could be further improved, e.g.
verify_auth,utils/auth.rs.