Improvement of OCW debugging and error handling #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4n0
changed the title
| // Start query at second block of a session | ||
| if index_in_session == 1 { | ||
| Self::start(block_number); | ||
| let _ = Self::start(block_number); |
Contributor
There was a problem hiding this comment.
The problem is, where is the Result of start consumed?
Satoshi-Kusumoto
approved these changes
Jul 27, 2021
Contributor
Satoshi-Kusumoto
left a comment
Satoshi-Kusumoto
left a comment
There was a problem hiding this comment.
Next time this kind of PR can not be passed since if you do not handle the result, the more addition is two logs.
Anyway please fire another issue of the TODO and fix it in no later than the next sprint
Contributor
Author
|
Yes thanks for mentioning this John. I will write an issue in case this is overlooked. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.