Skip to content

Replace hardcoded combo count with sizeof expression in test_h3_framing.c #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2025
Merged

Replace hardcoded combo count with sizeof expression in test_h3_framing.c #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62fd60b
Initial plan
Copilot Nov 27, 2025
fe1e24b
Replace hardcoded 6 with N_PWRITEV_COMBOS constant
Copilot Nov 27, 2025
c4182ff
Remove codeql artifact and add to gitignore
Copilot Nov 27, 2025
c86ca9b
Simplify: move combos to file scope and use sizeof directly
Copilot Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
_codeql_detected_source_root
21 changes: 11 additions & 10 deletions tests/test_h3_framing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,16 @@ test_pwritev (enum lsquic_version version, int http, int sched_immed,
}


static const struct { unsigned iovecs, frames; } combos[] =
{
{ 32, 16, },
{ 16, 16, },
{ 16, 8, },
{ 3, 7, },
{ 7, 3, },
{ 100, 100, },
};

static void
main_test_pwritev_combo (int combo_start, int combo_end)
{
Expand All @@ -1039,15 +1049,6 @@ main_test_pwritev_combo (int combo_start, int combo_end)
unsigned i, j, k;
enum lsquic_version version;
int http, sched_immed;
const struct { unsigned iovecs, frames; } combos[] =
{
{ 32, 16, },
{ 16, 16, },
{ 16, 8, },
{ 3, 7, },
{ 7, 3, },
{ 100, 100, },
};
int combo_idx;

s_can_write_ack = 1;
Expand Down Expand Up @@ -1078,7 +1079,7 @@ static void
main_test_pwritev (void)
{
/* Run all combos */
main_test_pwritev_combo(0, 6);
main_test_pwritev_combo(0, sizeof(combos) / sizeof(combos[0]));
}


Expand Down