feat: better handling of empty SQL files #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `/implement` command to execute implementation plans with automated testing and documentation workflows. - Introduced `/prd` command for creating research-grounded Product Requirements Documents (PRD) for complex features. - Created `/review` command to ensure high-quality code and documentation through a structured 5-phase review process. - Developed `/sync-guides` command to maintain documentation accuracy, ensuring guides reflect the current state of the codebase. - Established `/test` command for validating implementations through comprehensive testing strategies. docs: Add detailed guides for adapters and extensions - Added guides for `asyncpg`, `oracledb`, and `psycopg` adapters, outlining best practices, common issues, and driver features. - Introduced Google ADK Extension Guide detailing session persistence and event management with SQLSpec-backed stores. chore: Update AGENTS.md and agent specifications - Documented the workflow and responsibilities for each agent role: Expert, Guides, PRD, Review, and Testing. - Enhanced clarity on core responsibilities and mission statements for each agent to ensure alignment with project goals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the SQL file loader to gracefully skip files lacking named statements, preventing errors during loading. This change allows for seamless processing of directories containing both named queries and raw SQL scripts. Update tests to reflect the new behavior and ensure proper logging of skipped files.